898888 - Transition manager should use SetStyleContext rather than SetStyleContextWithoutNotification.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Transition manager should use SetStyleContext rather than SetStyleContextWithoutNotification.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Transition manager should use SetStyleContext rather than SetStyleContextWithoutNotification.

While debugging bug 858937 I noticed that the transition manager was
calling nsIFrame::SetStyleContextWithoutNotification rather than
nsIFrame::SetStyleContext.  SetStyleContextWithoutNotification should
only be used for things that aren't really style changes, but are
instead changes we make during frame construction before things are
really initialized.  Anything that's really a dynamic style change, as
these are, should use SetStyleContext.

I realize I said the opposite in bug 780692 comment 186, and bz said the
same in bug 780692 comment 204, which is why this is the state that it
is.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

bz, does this make sense to you as well?

Comment 4

[Nick Cameron [:nrc]]

Comment on attachment 782282 [details] [diff] [review]
Transition manager should use SetStyleContext rather than SetStyleContextWithoutNotification.

Review of attachment 782282 [details] [diff] [review]:
-----------------------------------------------------------------

Is it worth adding the explanation from your commit message as a comment for SetStyleContextWithoutNotification?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm.  Yeah, this makes sense.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=729da4b00a6c

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cafb82483526

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cafb82483526