Closed Bug 898898 Opened 6 years ago Closed 6 years ago

Add support for building on gonk-JB MR2

Categories

(Firefox Build System :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch support-mr2 (obsolete) — Splinter Review
This switches us to version 18 (JB MR2) and disables linking to dbus if bluetooth isn't enabled.
Attachment #782302 - Flags: review?(mh+mozilla)
s/OSLIBS/OS_LIBS/
Attachment #782302 - Attachment is obsolete: true
Attachment #782302 - Flags: review?(mh+mozilla)
Attachment #782315 - Flags: review?(mh+mozilla)
Comment on attachment 782315 [details] [diff] [review]
Add support for building on gonk-JB MR2

Review of attachment 782315 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/Makefile.in
@@ +29,5 @@
>    $(DEPTH)/media/libpng/$(LIB_PREFIX)mozpng.$(LIB_SUFFIX) \
>    $(DEPTH)/widget/gonk/libdisplay/$(LIB_PREFIX)display.$(LIB_SUFFIX) \
>    $(MOZ_ZLIB_LIBS) \
>    $(NULL)
> +ifeq (18,$(ANDROID_VERSION))

Why not keep support for version 17?
Attachment #782315 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #2)
> Why not keep support for version 17?

It simplifies things a little bit to only support 18, and I don't think we have any partners that are interested in supporting 17. 17 is also very likely to stop building soon even if we leave support in - people will be adding things that depend on 18 and there isn't much reason to spend time testing for compatibility on 17.
https://hg.mozilla.org/mozilla-central/rev/6477592cb574
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.