Closed Bug 898929 Opened 11 years ago Closed 11 years ago

"ASSERTION: Must have temporary surface to move pixels!"

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: jruderman, Assigned: nrc)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files, 1 obsolete file)

testcase
264 bytes, text/html
Details
stack
7.83 KB, text/plain
Details
patch
1.21 KB, patch
roc
: review+
Details | Diff | Splinter Review 
###!!! ASSERTION: Must have temporary surface to move pixels!: 'tmp', file /home/jruderman/mozilla-central/gfx/thebes/gfxASurface.cpp, line 526

Linux only?  Doesn't seem to happen on Mac.
Blocks: randomstyles
Attached file testcase — 

    
    

    
  

      
      
      
      

        Attached file
          
        stack
        — 
      

    


  

    
    

    
  
I could only repro this once and couldn't catch it in a debugger. But I'm guessing the issue is simply that we are requesting a really wide surface (400*the max width) and that is bigger than something along the line can handle. These limits are different on different platforms, so would explain why it doesn't assert on Mac (or Windows, I tested there).

Given that we sometimes expect CreateSimilarSurface to fail, and after the assert we return on a bad result (so we never crash on opt builds). I don't think we should worry about this. We could change the assert to a warning, I guess.

    
    

    
  
Downgrading the assertion to a warning sounds reasonable.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  
Assignee: nobody → ncameron

        Attachment #796446 -
        Flags: review?(roc)

    
    

    
  
Comment on attachment 796446 [details] [diff] [review]
patch

this patch is empty

        Attachment #796446 -
        Flags: review?(roc) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
With the actual changes this time. Sorry about that.

        Attachment #796446 -
        Attachment is obsolete: true

        Attachment #796467 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2e786cb19603
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: