898933 - Keypad add contact button not working

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

The add contact button from the dialer keypad does not update its state to enabled when digits are typed (i.e. dial screen is not empty), however tapping on it shows the action menu to create a new contact.

If the user then switches to the "Call Log" tab and returns to the dialer, tapping on the (disabled) add contact button doesn't display the action menu anymore.

STR:
1. Open Dialer - note: no number on dial screen, add contact button disabled
2. Start typing a number

Expected: the add contact button becomes enabled to allow saving the number

Actual: the add contact button doesn't change its displayed state (remains disabled), but properly reacts to taps unless the user switches to the "Call Log" and back

Does not reproduce on v1-train (7aaffc8), only on master (ad923e9).

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #11220 - Fix add contact btn behavior

This seems to have been caused by the patch for bug 892880, which removed the line that enabled the add contact button when digits are typed from the keypad.

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 782462 [details]
Pull Request #11220 - Fix add contact btn behavior

Stealing review from Etienne as he is on PTO and this is an obvious one-liner regression from bug 892880.

Thanks Mihai!

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Anthony! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/f103115a1d1905efdbaae9572a49ae276b929dda