Closed Bug 898940 Opened 6 years ago Closed 6 years ago
Audio controls missing when player started with play()
In the following minimal snippet, aurora makes the widget vanish while it is playing, and it only appears after playback finishes. If not intentional, then it's a regression from 22 and beta, if it is, then it seems like an undesirable feature, if there is no way to prevent it from occurring. <html><body> There should be an audio widget below here:<br> <audio id='player' src='foo.ogg' controls></audio> <br>There should be an audio widget above here. <script> document.getElementById('player').play(); </script> </body></html>
WFM on OS X Nightly with http://dolske.net/mozilla/tests/video/sizes_audio.html, what do you see?
The sizes_audio.html page works ok for me (they're crowded vertically, but otherwise work). The trick to the test code I posted though is the js play() operation. That's what makes the widget vanish in aurora. When it starts playing the widget disappears, when playing finishes it fades back in. Clicking the play button on the widget does not show this behaviour, that works fine too.
Regression range: good=2013-05-28 bad=2013-05-29 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c190422547ed&tochange=e58336e81395 Maybe Bug 876426.
Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/0f9247a41a5e Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130528 Firefox/24.0 ID:20130528065031 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/6a70ea277263 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130528 Firefox/24.0 ID:20130528070232 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0f9247a41a5e&tochange=6a70ea277263 Regressed by: 6a70ea277263 Robert O'Callahan — Bug 876380. Update 'show clickToPlay button' state after each load. r=dolske
Needinfo'ing :roc to get his insight on the issue as this may be FX24 regression if its a fallout form 876380 and the severity for it to be tracking worthy to understand its impact outside of the testcase.
It looks like the problem only occurs when the controls binding is attached after the element has started playing.
6 years ago
Assignee: nobody → roc
I haven't been able to run this test yet since running mochitests locally is currently broken on mozilla-central.
Attachment #784199 - Flags: review?(jaws)
Attachment #784156 - Flags: review?(jaws) → review+
Attachment #784199 - Flags: review?(jaws) → review+
https://bugzilla.mozilla.org/show_bug.cgi?id=898940 I'll land the test separately since I haven't run it yet.
Test seems to work. https://hg.mozilla.org/integration/mozilla-inbound/rev/b8f4739d9ff6
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #10) > https://bugzilla.mozilla.org/show_bug.cgi?id=898940 I meant to say https://hg.mozilla.org/integration/mozilla-inbound/rev/91f4bd08f12b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment on attachment 784156 [details] [diff] [review] fix [Approval Request Comment] Bug caused by (feature/regressing bug #): 876380 User impact if declined: audio elements with built-in controls may disappear (regression) Testing completed (on m-c, etc.): just landed Risk to taking this patch (and alternatives if risky): simple low-risk patch String or IDL/UUID changes made by this patch: none
Backed out for mochitest failures. https://hg.mozilla.org/releases/mozilla-beta/rev/f898cf4a4783 https://tbpl.mozilla.org/php/getParsedLog.php?id=26380276&tree=Mozilla-Beta
The test failed because the audio.ogg test file my test used isn't present on beta. I made the test use audio.wav which is present, and it passes. https://hg.mozilla.org/releases/mozilla-beta/rev/674ac4de277c https://hg.mozilla.org/releases/mozilla-beta/rev/3c7b2971e44f
You need to log in before you can comment on or make changes to this bug.