Exactly root the global JSObject*'s in testResolveRecursion

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 782411 [details] [diff] [review]
root_testResolveRecursion-v0.diff

As it says on the tin, this adds tracing for |obj1| and |obj2|.
Attachment #782411 - Flags: review?(sphink)
Comment on attachment 782411 [details] [diff] [review]
root_testResolveRecursion-v0.diff

Review of attachment 782411 [details] [diff] [review]:
-----------------------------------------------------------------

We probably don't do this anywhere else, but I'm thinking it might be a good idea to remove these roots at the end of the function, as defense against a future assertion that we don't have any lingering roots on shutdown.

Sadly, this really ought to be done with the AutoObjectRooter that I killed, but I certainly don't want to resurrect that. I think we can live with a shutdown leak in the failure case.
Attachment #782411 - Flags: review?(sphink) → review+
Blocks: 898606
No longer blocks: 753203
(Assignee)

Comment 2

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/895d95fc58bb
https://hg.mozilla.org/mozilla-central/rev/895d95fc58bb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.