5 years ago
Assignee: nobody → arnau
Created attachment 784931 [details] patch in github
Comment on attachment 784931 [details] patch in github This patch looks robust, anyway i will feel more confortable if some Gaia peer take a look at the webapp-zip.js also. Thx guys!
Attachment #784931 - Flags: ui-review?(igonzaleznicolas) → ui-review+
5 years ago
Attachment #784931 - Flags: review?(francisco.jordano) → review?(timdream)
Comment on attachment 784931 [details] patch in github I would like to have Vivien to review the patch too. Also I think Yuren could read through the webapps-zip.js part. Please removing the type as originally planned.
Comment on attachment 784931 [details] patch in github looks fine for me, but please make sure you have tested it on windows.
Attachment #784931 - Flags: feedback?(yurenju.mozilla) → feedback+
Comment on attachment 784931 [details] patch in github I don't have the bandwidth to r? this correctly but from what I've understood of the patch f+.
Attachment #784931 - Flags: review?(21) → feedback+
Comment on attachment 784931 [details] patch in github Please, let’s not merge that today: the “Building Blocks v2” aren’t ready yet and they’ll change a lot in the next few weeks (hopefully). Before we can document and finalize the class names, we need to have the “full picture” — which supposes at least these three steps imho: • have a v2 stylesheet for *every* Building Block (we only have “headers.css” so far and its class names are likely to change); • (my preferred part) bikeshed about class names so that they make sense for designers, UX engineers and developers; • have an expert review on the whole, especially a maintainability evaluation. One of the reasons why the current shared/style folder has become “what it is” is that it’s very difficult to improve these shared stylesheets once they’re used by apps. Let’s not repeat this mistake, please. Once our v2 Building Blocks become usable, applying this patch and starting the upgrade will still be doable. There’s no point in rushing this patch.
Attachment #784931 - Flags: feedback-
We won't work on that by now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.