899015 - [Settings][WIFI][Helix] The SSID overlaps the WIFI icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[William Hsu [:whsu]]

Attachment: SSID overlaps the WIFI icon

* Description:
  This is a legacy bug. I found it on Helix V1.1.0 HD build.
  The V1-TRAIN had the same problem.
  If the WIFI SSID is longer than 23 characters, the WIFI-SSID will overlap the WIFI icon
  Please see attachment to know the detail.

* Precondition:
  WIFI's SSID is longer than 23 characters.

* Reproduction steps:
  1. Launch settings app
  2. Tap the WIFI settings
  3. Swipe to the "Available networks" and find the long SSID network.

* Expected result:
  The SSID should be trimmed into suitable size without overlapping the WIFI icon

* Actual result:
  The SSID overlaps the WIFI icon

* Reproduction build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-07-25-07-02-02)
  + Mercurial-Information
    - Gecko revision="2bb08f2878da"
  + Git-information
Gaia revision="f2bc4a004f592cd6dce4edda2b0533f4fd4f91f2"

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Requesting UX input on a possible solution: should the SSID be truncated with ellipsis in order to not overlap the Wi-Fi icon?

Comment 2

[William Hsu [:whsu]]

I am not UX. But we may follow the FTU's design. Attaching the screenshot.

Comment 3

[William Hsu [:whsu]]

Attachment: WIFI layout in FTU

Comment 4

[Stephany Wilkes]

Flagging Neo to advise on layout issues. Neo, please reassign to VxD or someone else as necessary.

Comment 5

[Wayne Chang [:wchang]]

bumping to leo?

> * Description:
>   This is a legacy bug. I found it on Helix V1.1.0 HD build.
>   The V1-TRAIN had the same problem.

Comment 6

[Wayne Chang [:wchang]]

Triage - not blocking for partners.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Not a blocker since it's been present since v1.0.1 - we can take a fix on trains when ready.

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #11331 - Fix WiFi label overlap with icon

Since the WiFi icon has "position: absolute", it's width was not affecting the WiFi SSID text label width -- this patch sets it explicitly for the WiFi available networks list.

Comment 9

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/95ea83222951e6248cef23fdc135513da0b4c647

Comment 10

[William Hsu [:whsu]]

Hi, all,

Thanks for your help!
I cannot reproduce this bug on following build.
* Test Build:
 - Gaia:     1518b76c07c4d70fc41113ed2e424a74b2bcef27
 - Gecko:    http://hg.mozilla.org/mozilla-central/rev/1d27c4c9871f
 - BuildID   20130917040201
 - Version   26.0a1

Attaching the screenshot.


--------- Marked it as "FIXED" ---------

Comment 11

[William Hsu [:whsu]]

Attachment: UI trunctation of WIFI settings page