899069 - Automatic update for l10n nightly builds not working because update.php script returns wrong address

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Christoph Kaulich]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130725195523

Steps to reproduce:

Trying to update the nightly builds by the update mechanism, using earlybird on windows with a german localisation.


Actual results:

I get the error console with 

Zeitstempel: 29.07.2013 15:56:37
Warnung: WARN addons.xpi: Download failed: 404 Not Found
Quelldatei: resource://gre/modules/XPIProvider.jsm
Zeile: 5115


Expected results:

Update should start.

Comment 1

[Stefan Sitter [:ssitter]]

You can set the advanced preference "extensions.logging.enabled" to "true". This should provide additional output in Error Console including the URL that is received for the Lightning nightly update package. Please test and post the result here.

Comment 2

[Christoph Kaulich]

Hi, 

it tries t download the localized builds from the 'not l10n' directory:

LOG addons.xpi: Download started for https://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-aurora/lightning-2.7a2.de.win32.xpi to file C:\Users\kaulich\AppData\Local\Temp\tmp-uzg.xpi

Comment 3

[Christoph Kaulich]

Still true for 2.9a2 on a german windows.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hi Christoph, sorry for the delay. With logging enabled, does it tell you from which URL its downloading the update info? It should start with: https://calendar.mozilla.org/update.php

Comment 5

[Stefan Sitter [:ssitter]]

Problem is that the returned download link points to latest-comm-central / latest-comm-aurora folder, e.g. .../nightly/latest-comm-central/lightning-3.0a1.de.win32.xpi where the file is not found.

For non en-US builds it should point to the correct l10n sub-folder, e.g. .../nightly/latest-comm-central-l10n/win32/lightning-3.0a1.de.win32.xpi

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, I'm just looking for the request URI so I can reproduce. I admit I haven't tried it myself, but I thought since one of you must surely have update logging enabled it would be easy to figure out?

Comment 7

[Christoph Kaulich]

LOG addons.updates: Requesting https://calendar.mozilla.org/update.php?buildID=20131130030208&appABI=x86-msvc&appOS=WINNT&locale=de&appVersion=28.0a1&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}

Comment 8

[Christoph Kaulich]

1395407226916	addons.xpi	WARN	Download of https://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-comm-central/lightning-3.3a1.de.win32.xpi failed

Comment 9

[Martin Schröder [:mschroeder]]

Please, everyone test the update for nightly and alpha Lightning builds as a new update logic is live now.

Comment 10

[Christoph Kaulich]

The check seems to work, as it finds now an update on every start of thunderbird, even if the nightly of lightning was not rebuild.
So maybe the check of the build date has to be improved.
TB 32, lightning 3.4

Comment 11

[Martin Schröder [:mschroeder]]

(In reply to Christoph Kaulich from comment #10)
Christoph, thanks for your feedback. I will have a look at the script and try to improve the situation concerning the download of the same build again.

Comment 12

[Martin Schröder [:mschroeder]]

(In reply to Martin Schröder [:mschroeder] from comment #11)
> (In reply to Christoph Kaulich from comment #10)
> Christoph, thanks for your feedback. I will have a look at the script and
> try to improve the situation concerning the download of the same build again.

Please, have a look at bug 1044955 for an explanation of the update behavior.