Closed Bug 899108 Opened 11 years ago Closed 11 years ago

Using friendly code as a submodule makes it really difficult to update UI in thimble

Categories

(Webmaker Graveyard :: Thimble, defect)

Product:
Webmaker Graveyard
Component:
Thimble
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kate, Unassigned)

Details

After investigating possible options for implementing various interface and publishing changes in bug890675 and bug896494, it seems to me like having all of the UI for friendlycode inside a submodule is kind of blocking our ability to make substantial front-end changes to Thimble. Some of the UI we need is specific to makeapi metadata and Thimble -- so I'm not sure how appropriate it would be to add that into friendlycode. It would also be very strange/difficult to separate that webmaker-specific UI out while still also using friendlycode's UI. Right now part of our solution is to use an override stylesheet with !important, but I don't think that's a very sustainable solution going forward considering that it makes styles difficult to inspect/maintain and doesn't allow for changes in the HTML structure. Possible options: - Changing friendlycode to expose functions like publishing/adjusting font size/etc. instead of dealing with UI directly (not easy) - Merging friendly code into Thimble (also not easy) - adding changes directly into friendly code, assuming Thimble is our primary use case and we don't care about it being stand-alone This seems like a hard problem to me. What do you guys think?
Similar to what we did with Popcorn Maker vs Butter, why not fork friendlycode and include it directly in the repo for thimble.webmaker.org? I don't think we care about maintaining an editor component in general, just in using it ourselves. Maintaining upstream compat here is noble, but unnecessary imho.
since friendlycode already lives on mozilla's repo, I'd say branch it rather than fork, and then we don't have to worry about adding remotes everytime the project is checked out when we do the submodule init.
friendlycode and slowparse got un-submoduled.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.