899122 - Include previously downloaded data in progress reports when restarting

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Paolo Amadini]

When a download is restarted from where it stopped, progress reports should
include the bytes that were already downloaded. This provides a more intuitive
behavior to the progress bar in the user interface.

Comment 1

[:Paolo Amadini]

Attachment: The patch

The setSha256Hash fix is unrelated, but it fixed an issue I encountered while
testing this patch in the user interface.

Comment 2

[Neil Deakin]

Comment on attachment 783719 [details] [diff] [review]
The patch

>+  // Continue when the number of bytes we received is correct, then check that
>+  // progress is at about 75 percent (while the exact figure may vary).
>+  yield deferMidway.promise;
>+  do_check_true(download.progress > 72 && download.progress < 78);

Why isn't this exactly 75%?

Comment 3

[:Paolo Amadini]

(In reply to Neil Deakin from comment #2)
> Why isn't this exactly 75%?

We have rounding issues because the total number of bytes in the request isn't a
multiple of four. I can clarify the comment.

Comment 4

[:Paolo Amadini]

Updated to:

  // Continue when the number of bytes we received is correct, then check that
  // progress is at about 75 percent.  The exact figure may vary because of
  // rounding issues, since the total number of bytes in the response might not
  // be a multiple of four.

Comment 5

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/ff1477ebf69e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ff1477ebf69e