899124 - Compute download speed and throttle notifications

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Paolo Amadini]

The JavaScript API for downloads should compute the current speed of
in-progress downloads, and limit the rate of progress notifications.

Comment 1

[formerly wakaflocka]

Will this mean download speeds will be shown in the UI?

Comment 2

[:Paolo Amadini]

(In reply to Waka_Flocka_Flame from comment #1)
> Will this mean download speeds will be shown in the UI?

The speed is already shown in the Library window, and there are plans to show the
current speed in the Downloads Panel also, yes.

Comment 3

[formerly wakaflocka]

okay

Comment 4

[:Paolo Amadini]

Attachment: The patch

This also fixes a typo that affected removing items from the Downloads Panel.

This cannot be tested automatically since it's time-based. I tested it manually
by seeing that the download speed and the remaining time is now correctly
reported in the Library window for in-progress downloads.

Comment 5

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/573d656dadcf

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/573d656dadcf

Comment 7

[Mihai Morar, (:MihaiMorar)]

Download speed is shown only on Library->Downloads. It is not shown on the Downloads Panel. Only remaining time and download indicator are displayed.

OS: Windows 7x64 
Build: Latest Nightly27 BuildID: 20131009055629