899186 - We shouldn't display a message when pressing call with an empty call log

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

I think the "No previous outgoing calls" when you have nothing in your call log is useless and confusing. This case will only happen when you use the phone for the first time or so. And I think silently failing is better.

If we could remove it, we reduce our codebase and our l10n.

https://www.dropbox.com/s/zu2is80w1ktyt44/2013-07-24%2017.40.20.mp4

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

+1 to Antony proposal :)

Comment 2

[Stephany Wilkes]

Flagging Francis to advise on the removal of "no previous outgoing calls" and silently failing instead. Need to balance the Mozilla advantages of reduced codebase and l10n with users understanding what's happening.

Comment 3

[Francis Djabri [:djabber]]

The reason the error message was included was because it is part of the acceptance criteria for the bug. From a UX perspective however, I am OK with silently failing.

Comment 4

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11297

Pointer to Github pull-request

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 784374 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11297

Working nice, patch that simplifies the code, r+ my only concern is for QA people that are going to test this feature to be sure the tests cases are updated.

Thanks Anthony!

Comment 6

[Anthony Ricaud (:rik)]

Merged with https://github.com/mozilla-b2g/gaia/commit/214580b84b047b3f077bf5fa740a09150fb5ae46