899201 - Warn users when they add youtube clips in Popcorn Maker

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Brett Gaylor [:brett]]

We've recently seen a lot of user reports complain about popcorn makers performance when they use multiple clips, specifically with preloading.

We will never make it possible to load clips from the web instantly, yet users expectations will likely always be that they can use popcorn maker as a non linear video editor.

We could help these expectations by warning them when they add more than 2 clips.  if they use more than 2 media files, we could surface a dialogue similar to the crash report that says "Using more than 2 media files will greatly increase your load time, and may cause issues with playback on slower connections"

Comment 1

[Scott [:thecount] Downe]

Thoghts:

I think you're hinting at having this dialog in the media gallery? If so, I like that. If more than 2 clips are added to the media gallery display some dialog.

I am kinda thinking the dialog should point out that the issue is when, or is worse when, multiple clips are at the same time, not necessarily in the project overall.

Also, not sure we need to say how many clips we use to trigger this. It is fairly subjective.

Do you think we should use something like this:

"Using multiple clips at the same time will greatly increase your load time, and may cause issues with playback on slower connections."

So, I did not say more than two, but we do trigger this when they add more than two. Wonder if we should hide that or not.

Anyway, I agree where this is going and am not married to my proposed dialog, as I know we can iterate on it, just throwing out ideas.

Comment 2

[Brett Gaylor [:brett]]

As discussed IRL, this should be something that the user dismisses and should only happen the first time a clip is added

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/169

This could use some better text, but implementing it is easy enough.

Comment 4

[Brett Gaylor [:brett]]

Awesome - let's use this.

"If you add a large number of clips to your timeline, this could reduce playback quality for people with slower internet connections. Click <a href=\"#\" class=\"close-button\">here</a> to remove this warning."

Comment 5

[Scott [:thecount] Downe]

Interesting approach.

What Matt's doing in this patch is displaying the warning when a clip is added to the timeline, and not the gallery.

It also displays the warning along the top, using the same out of date flash version warning, and older browser warning.

I *think* the original idea was to put the warning in the media gallery editor, and to trigger when clips are added to the media gallery.

Should show Brett what you've got, see what he thinks. Might be pretty annoying to have use this warning, it's a pretty agressive one.

Thoughts?

Comment 6

[Matthew Schranz [:mjschranz]]

Based on the copy Brett provided, It looks like he intended it to be in that area. The close button is a big give away on this.

I like it where it is because it simply builds of warning UI we already use. The text we put inside other editors are actual errors from user input while editing an event. This is not an error, it's merely a suggestion like our other warnings.

That's my view on it.

Comment 7

[Brett Gaylor [:brett]]

I did think it would be in media editor, but i think it works when adding to the timeline, too.  can you put it on a heroku or something and i can take a look?

Comment 8

[Scott [:thecount] Downe]

I kinda like it limited to the gallery editor as much as possible. It is simple, is the main place to do this, and less obstructive.

I'm also wondering if we should have it persist, so users who come from a remix that already has 3-4 clips in the gallery editor sees it. Obviously, if it persists, it has to be as non obstructive as possible.

Comment 9

[Brett Gaylor [:brett]]

Ok, Scott - that makes sense. Do you guys need to take a different approach altogether then?

Comment 10

[Matthew Schranz [:mjschranz]]

The media editor UI as it stands right now definitely doesn't support the kind of error message I think we want. It doesn't use the standard trackevent editor error message system.

Do we really want the message appearing inside the editor? Do we also want this to happen once they add a clip to the gallery, or to the timeline?

Comment 11

[Scott [:thecount] Downe]

Yeah, I want it in the gallery, and I want it to happen when adding to the gallery.

Having it at the top is far too distracting. That area of the screen would not have their attention while adding a clip. I also want the distracting nature of it to be limited to a less used act, which is adding to the gallery.

I'm not sure yet if it should persit or not, but I am leaning towards it persisting if UI can accommodate it. But I would rather it go away if it means a gross UI solution.

Comment 12

[Matthew Schranz [:mjschranz]]

If we are going to put it inside the media editor, I'm highly against it being persistent. Space is at a premium in there, especially with the work I'm doing for media sync.

Comment 13

[Scott [:thecount] Downe]

Media sync is going to need a lot of design.

I think we need to break that editor up into other things. Putting media sync in there might not be the best solution.

Consider searching youtube for gallery items. Everything you search for should not become gallery items, but needs to go somewhere, and then when one search item is selected, that one then goes into the media gallery. Maybe media sync should work like that too? Another way/window/tab/editor to get things into the media gallery. Maybe open a new editor over the gallery, with a breadcrumb like we do for track event editors?

Comment 14

[Chris DeCairos (:cade)]

Popcorn Maker is no longer under active development.

https://learning.mozilla.org/blog/product-update-for-appmaker-and-popcorn-maker