899230 - domUtils.getCSSValuesForProperty returns "logical" and "physical" which should not be in any list

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Girish Sharma [:Optimizer]]

These two values are present in various property list like border-width, border-color, etc. they should not be present as they do not work in websites and are not in spec.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The issue is the *-source properties...

Mina, I think we should just bail out of GetKeywordsForProperty if keywordTable is kBoxPropSourceKTable.  Make sense?

Comment 2

[Mina Almasry]

Attachment: Patch

Ya that makes sense. Here is a patch. I still can't run mochitests (bug in mach) so here is a try push...?

https://tbpl.mozilla.org/?tree=Try&rev=40faa886af88

Comment 3

[Mina Almasry]

Never mind someone on the IRC helped me with running the test without mach. It passes. Patch just needs a review then.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 782933 [details] [diff] [review]
Patch

> +  if (keywordTable && (keywordTable != nsCSSProps::kBoxPropSourceKTable)) {

Drop the extra parens, please.

r=me

Comment 5

[Mina Almasry]

Attachment: patch with change

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0eccf52bf215

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0eccf52bf215