899325 - Close sCompositorChild when shutting down

Status: RESOLVED DUPLICATE of bug 845982

(Core :: Graphics: Layers, defect)

Description

[Joe Drew (not getting mail)]

Attachment: close-compositor

Looks like we had some problems that needed to be solved, but they mostly were solved, and so now we should just be able to close sCompositorChild (correctly killing the protocols, subprotocols, etc) when we need to.

https://tbpl.mozilla.org/?tree=Try&rev=73487d37e7af

Comment 1

[Benoit Girard (:BenWa)]

You might want to run this also on Android/B2G debug but certainly Mac OMTC will catch the most obvious problems.

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 782794 [details] [diff] [review]
close-compositor

Review of attachment 782794 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/nsBaseWidget.cpp
@@ +150,5 @@
>  static void DeferredDestroyCompositor(CompositorParent* aCompositorParent,
>                                CompositorChild* aCompositorChild)
>  {
>      // Bug 848949 needs to be fixed before
>      // we can close the channel properly

Lets also remove the comment.

Comment 3

[Joe Drew (not getting mail)]

This patch is wrong, but bug 845982 is right and does the same thing.