[Mac HiDPI]: HiDPI icons are not respected in system menu

RESOLVED FIXED in mozilla33

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Nomis101, Assigned: mstange)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 782797 [details]
Screenshot of the issue in Firefox

I've noticed this first for Thunderbird in 898537. It was also mentioned there that this could be a toolkit bug. Than I found out, that Firefox is using also HiDPI images in the system menu (query@2x.png, bookmarksToolbar@2x.png...) and this images are also blurry on my Retian MacBook Pro. The PNGs of this icons are totaly fine and sharp.
Tested with Firefox 22 and the latest nightly.

Interesting to mention is also that the Apple own icon under "Services -> Services Preferences..." is perfectly sharp and not affected.
(Assignee)

Comment 1

4 years ago
Created attachment 8457897 [details] [diff] [review]
patch

The FLAG_SYNC_DECODE change is unrelated but correct and consistent with nsCocoaUtils::CreateNSImageFromImageContainer.
Attachment #8457897 - Flags: review?(smichaud)
Comment on attachment 8457897 [details] [diff] [review]
patch

This looks fine to me, and I like the simplification.

But frankly my eyes aren't good enough to tell whether or not it works, HiDPI-wise.
Attachment #8457897 - Flags: review?(smichaud) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/333460ebc613
Assignee: nobody → mstange
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/333460ebc613
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1068417
You need to log in before you can comment on or make changes to this bug.