Closed
Bug 899339
Opened 11 years ago
Closed 11 years ago
Refactor marionette-js-client internals so we can create an object without a driver.
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Unassigned)
References
Details
Attachments
(1 file)
needed so we can expose an api like this: https://gist.github.com/lightsofapollo/6107490
|
Reporter | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 782801 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/marionette_js_client/pull/37 Sending to Gareth but I invited others to review as well.
Attachment #782801 -
Flags: review?(gaye)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #782801 -
Flags: review?(gaye) → review?(mike)
|
||
Comment 3•11 years ago
|
||
Looks good to me! I just have one suggestion related to cleaning up some code you moved--see the pull request on GitHub for details
|
|
Reporter | |
Comment 4•11 years ago
|
||
https://github.com/mozilla-b2g/marionette_js_client/commit/ecca5d20da52a0351a19164031fc42bb13c1f7c4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 782801 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/marionette_js_client/pull/37 Looks like I forgot to set the review flag on this one. Sorry about that--I'll set it now for accounting purposes
Attachment #782801 -
Flags: review?(mike) → review+
|
||
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•