Closed
Bug 899484
Opened 11 years ago
Closed 11 years ago
(follow-up for bug 869768) [B2G][CDMA] Set and Query the roaming preference in CDMA
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox26 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(2 files)
2.36 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
3.58 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #869768 +++ Please see bug 869768 comment #34.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Although emulator runs as GSM mode by default and will response "not support" error for roaming preference command. But these tests still can help us to make sure ril did process request correctly.
Assignee | ||
Updated•11 years ago
|
Attachment #783065 -
Flags: review?(htsai)
Assignee | ||
Updated•11 years ago
|
Attachment #783067 -
Flags: review?(htsai)
Comment 3•11 years ago
|
||
Comment on attachment 783065 [details] [diff] [review] Part 1: Use sendChromeMessage to send message instead of using sendDOMMessage, v1 Thank you!
Attachment #783065 -
Flags: review?(htsai) → review+
Comment 4•11 years ago
|
||
Comment on attachment 783067 [details] [diff] [review] Part 2: Add marionette tests for roaming preference, v1 Review of attachment 783067 [details] [diff] [review]: ----------------------------------------------------------------- Nice! Thank you.
Attachment #783067 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Try server: https://tbpl.mozilla.org/?tree=Try&rev=2014e53ad275
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/f3536cea7d3f https://hg.mozilla.org/projects/birch/rev/64a7109de1ba
Whiteboard: [fixed-in-birch]
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3536cea7d3f https://hg.mozilla.org/mozilla-central/rev/64a7109de1ba
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•11 years ago
|
status-firefox26:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•