Closed Bug 899504 Opened 6 years ago Closed 6 years ago

ASan: test_memoryReporters.xul fails due to unreasonable vsize

Categories

(Toolkit :: about:memory, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [asan-test-failure])

Attachments

(1 file, 1 obsolete file)

The test at toolkit/components/aboutmemory/tests/test_memoryReporters.xul checks that the vsize is "reasonable". Under AddressSanitizer, the vsize is the maximum possible value because ASan uses this mechanism to manage its shadow memory.

Therefore, this check (and probably the whole test), doesn't make much sense under ASan and I'd like to disable it when MOZ_ASAN is set.
Component: Plug-ins → about:memory
Product: Core → Toolkit
Attached patch bug899504-memory-vsize.patch (obsolete) — Splinter Review
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #783123 - Flags: review?(ted)
Now with actual usefulness (tm)
Attachment #783123 - Attachment is obsolete: true
Attachment #783123 - Flags: review?(ted)
Attachment #783125 - Flags: review?(ted)
Attachment #783125 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/47b0b4f9debf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.