Closed
Bug 899504
Opened 12 years ago
Closed 12 years ago
ASan: test_memoryReporters.xul fails due to unreasonable vsize
Categories
(Toolkit :: about:memory, defect)
Toolkit
about:memory
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: decoder, Assigned: decoder)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want, Whiteboard: [asan-test-failure])
Attachments
(1 file, 1 obsolete file)
894 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The test at toolkit/components/aboutmemory/tests/test_memoryReporters.xul checks that the vsize is "reasonable". Under AddressSanitizer, the vsize is the maximum possible value because ASan uses this mechanism to manage its shadow memory.
Therefore, this check (and probably the whole test), doesn't make much sense under ASan and I'd like to disable it when MOZ_ASAN is set.
Assignee | ||
Updated•12 years ago
|
Component: Plug-ins → about:memory
Product: Core → Toolkit
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Comment 2•12 years ago
|
||
Now with actual usefulness (tm)
Attachment #783123 -
Attachment is obsolete: true
Attachment #783123 -
Flags: review?(ted)
Attachment #783125 -
Flags: review?(ted)
Updated•12 years ago
|
Attachment #783125 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•