ASan: test_memoryReporters.xul fails due to unreasonable vsize

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: decoder, Assigned: decoder)

Tracking

(Blocks: 1 bug, {sec-want})

Trunk
mozilla25
sec-want
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [asan-test-failure])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The test at toolkit/components/aboutmemory/tests/test_memoryReporters.xul checks that the vsize is "reasonable". Under AddressSanitizer, the vsize is the maximum possible value because ASan uses this mechanism to manage its shadow memory.

Therefore, this check (and probably the whole test), doesn't make much sense under ASan and I'd like to disable it when MOZ_ASAN is set.
(Assignee)

Updated

6 years ago
Component: Plug-ins → about:memory
Product: Core → Toolkit
(Assignee)

Comment 1

6 years ago
Created attachment 783123 [details] [diff] [review]
bug899504-memory-vsize.patch
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #783123 - Flags: review?(ted)
(Assignee)

Comment 2

6 years ago
Created attachment 783125 [details] [diff] [review]
bug899504-memory-vsize.patch

Now with actual usefulness (tm)
Attachment #783123 - Attachment is obsolete: true
Attachment #783123 - Flags: review?(ted)
Attachment #783125 - Flags: review?(ted)
Attachment #783125 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/47b0b4f9debf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.