899551 - Splinter doesn't linkify review comments

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: Splinter, defect, P5)

Description

[(no longer active)]

See <https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=872127&attachment=782711> for example.

Comment 1

[David Lawrence [:dkl]]

After trying a few, I was not able to get this to fail for me. Is there a specific review comment that is not working or all? Can you take a screenshot of the comment and I will see if that specific one works for me.

dkl

Comment 2

[(no longer active)]

Really?  Just scroll down to the first review comment on configure.in.  There is an mxr link there which is not linkified.

Comment 3

[David Lawrence [:dkl]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> Really?  Just scroll down to the first review comment on configure.in. 
> There is an mxr link there which is not linkified.

Sorry I misunderstood from you summary and description and thought you meant the linking of a review comment on that page to it's relevent section in the diff under review. Not the actual links in the comment itself. We would need to redo the way the linking of the entire block works and create a [link] link or similar for the comment/context. Then we could possibly do linkification of other links in the comment text itself. 

Not sure if we are going to go this far into the Splinter code to make a change like this as we are discussing moving off of Splinter entirely to something else like ReviewBoard (bug 874767). 

dkl

Comment 4

[Kohei Yoshino [:kohei]]

Splinter is retiring.