Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aklee237, Assigned: pomax)

Tracking

Details

(Whiteboard: s=20130729 p=1)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 783126 [details]
ccsslideshow.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.72 Safari/537.36

Steps to reproduce:

Trying to get this sliding image gallery to work in Thimble. 




Actual results:

They work fine in the editor but once you publish the page the effect disappears. I don't get any error messages


Expected results:

I am perplexed as to what the issue is. It might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=869164

Updated

5 years ago
Assignee: nobody → pomax
(Assignee)

Comment 1

5 years ago
From https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/bleach.js#L126 it looks like label has no permitted attributes bound for it atm.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Updated

5 years ago
Whiteboard: s=20130729 p=1
(Reporter)

Comment 2

5 years ago
thanks for the update, I'm going to use a minecraft thimble template for the Maker Party instead.
Attachment #783957 - Flags: review?(scott) → review+

Comment 4

5 years ago
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/f4eaea548f03244c56db03475bf6a071865ffd19
Merge pull request #193 from Pomax/bug899553

added label attributes to bleach
(Assignee)

Comment 5

5 years ago
landed. This will have to go through staging before it hits production, though.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.