899553 - css sliding images

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[aklee237]

Attachment: ccsslideshow.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.72 Safari/537.36

Steps to reproduce:

Trying to get this sliding image gallery to work in Thimble. 




Actual results:

They work fine in the editor but once you publish the page the effect disappears. I don't get any error messages


Expected results:

I am perplexed as to what the issue is. It might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=869164

Comment 1

[Pomax]

From https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/bleach.js#L126 it looks like label has no permitted attributes bound for it atm.

Comment 2

[aklee237]

thanks for the update, I'm going to use a minecraft thimble template for the Maker Party instead.

Comment 3

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/193

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/f4eaea548f03244c56db03475bf6a071865ffd19
Merge pull request #193 from Pomax/bug899553

added label attributes to bleach

Comment 5

[Pomax]

landed. This will have to go through staging before it hits production, though.