89958 - color picker behavior for last-picked color button

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

I don't like the current behavior for the color picker's "last-picked color" 
button.  Current, when you click it, it sets the color in the edit field and sets 
the color swatch but the color picker stays up.  I'd prefer that the color picker 
dismiss when I click that button.  It's really not much of a short cut if I have 
to click so many things to get it (color picker control, last-picked button, ok 
button).

Comment 1

[Charles Manske]

Design is on purpose, so you can see the color value in the edit field and 
possibly modify it. Note that the "Last Picked Color" is initially the default
key, so all you have to do for quicker access is press Enter/Return.
The quickest access to the last-picked color is Shift+click on the toolbar 
buttons. The text or background color is applied without even bringing up the
dialog.

Comment 2

[Kathleen :Brade]

Being able to edit the last picked color doesn't really seem very useful (so 
useful to warrant requiring an extra click from users).

The shortcut you describe with pressing enter/return does not seem to work.  When 
I press return, I get the current color (like if I pressed cancel) instead of the 
"last picked" color.

As for the "quickest" access, that is hardly quick.  I wouldn't remember such a 
thing so I'd have to look it up which would take much longer.  I don't think this 
shortcut is intuitive or easily discovered.

We should make the last picked color button actually dismiss the dialog.

Comment 3

[Charles Manske]

I agree, it would be better to simply close the dialog. Trivial to fix.
Nominating for 0.9.3.

Comment 4

[Charles Manske]

Attachment: Close dialog after selecting last-picked color

Comment 5

[Charles Manske]

r=mjudge

Comment 6

[Charles Manske]

Per discussion with beppe, setting nsBranch.

Comment 7

[kinmoz]

sr=[e-mail]

Comment 8

[Charles Manske]

checked into trunk

Comment 9

[rubydoo123]

adding nsBranch+

Comment 10

[Charles Manske]

This will not be checked into branch for NS 6.1 release. 

Comment 11

[sujay]

Shouldn't this bug be marked RESOLVED-FIXED? Charley says he fixed
it in the trunk and its not gonna be fixed in the branch...

Comment 12

[sujay]

I just downloaded the 7/11 trunk on windows...

this is not fixed. the dialog does not close after
clicking on "Last-picked color"

Comment 13

[Charles Manske]

Right, this isn't finished yet and is not nominated for 6.1 release.
To fix this properly, I should modify or remove the extra code that shifts 
the default button (what fires when "Enter" is pressed) from "Last Picked Color"
to "Ok". This will be done in next cycle.

Comment 14

[sujay]

Charley I understand its not fixed on the branch.

but its not even fixed on the trunk...see  your comments above: "checked into
the trunk"  <---doesn't this mean that its fixed on the trunk and I should
verify it on the trunk? someone also added the "vtrunk" keyword.

Comment 15

[Charles Manske]

Yes IT IS NOT FIXED on branch or trunk. Ignore 'checked in'. I removed the 
'vtrunk' keyword.

Comment 16

[Charles Manske]

Attachment: Updated patch.

Comment 17

[Charles Manske]

The "change default button" code is still useful for keyboard-only users.
Updated patch simply closes the window after setting the color in the OnOK()
method.

Comment 18

[Kathleen :Brade]

r=brade

Comment 19

[kinmoz]

sr=[e-mail]

Comment 20

[Charles Manske]

checked in.

Comment 21

[James Baxter]

Verified on 8-30 Build