899582 - Deleted versions aren't being indicated as Deleted in the review history

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Andrew Williamson [:eviljeff]]

Looking at:
https://marketplace.firefox.com/reviewers/apps/review/zolal

it has 9 versions shown, but 6 of them are deleted and they are no longer indicated as such.  Instead they show the state they had when they were deleted (pending full review).

Comment 1

[Andrew Williamson [:eviljeff]]

I did recently add a commit that changed status text (https://github.com/eviljeff/zamboni/commit/13a62d8e7ccbf4c7576156d7152fd411cf9dca56) but, afaik, it only affected the display of moz-disabled/rejected states and I added/removed no logic around deleted or not.

Comment 2

[Andrew Williamson [:eviljeff]]

deleted version support added in
https://github.com/mozilla/zamboni/commit/3d2c962f167ff5d6b3178dee353b9d363d858daf
if that helps

Comment 3

[Andrew Williamson [:eviljeff]]

narrowed it down to the fix ngoke made in https://github.com/mozilla/zamboni/commit/43935dfb70fffeb6563a25081e767eda0f6e4773#apps/editors/helpers.py 

- previously https://github.com/mozilla/zamboni/blob/master/apps/versions/models.py#L351 was called which added the status of deleted; after the fix the version status is instead the concatenation of the file statuses, which don't have (?) a deleted status.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/543d65

Comment 5

[Victor Carciu]

Verified as fixed. Deleted versions are displayed as "Deleted" : http://screencast.com/t/fANe09wJV