Closed
Bug 899604
Opened 12 years ago
Closed 12 years ago
Fix problem with unsupported locale which doesn't default to en-US
Categories
(Webmaker Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: alicoding)
Details
Attachments
(1 file)
thornet: reported on IRC that there are missing text on the page and when clicking on any of the link it will redirect her to a 404 because of the link is broken.
:humph and I investigate the issue and I have come to a conclusion that we should support both locale version because for some user if the request page the accept-language was 'en' the header would be set to 'en_US' which will result of string requested not found in i18n-abide.
Adding support both version will solve this problem.
|
||
Comment 1•12 years ago
|
||
One question I have is where in the chain it went from `en` to `en_US`? The l10n-abide module knows about lang and locale and can convert between the two, see https://github.com/mozilla/i18n-abide/blob/master/lib/i18n.js#L318-L363. What goes in the <html lang="xx"> attribute should be a language (en-US) and not a locale (en_US).
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → ali
Status: NEW → ASSIGNED
Summary: Add support both locale xx-YY and xx_YY on i18n-abide → Fix problem with unsupported locale which doesn't default to en-US
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #783237 -
Flags: review?(david.humphrey)
|
|
||
Updated•12 years ago
|
Attachment #783237 -
Flags: review?(david.humphrey) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/edb6abd112b4eed9365c1c85f82796f5c10c5323
Bug 899604 - Fix problem with unsupported locale which doesn't default to en-US
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•