Closed Bug 899614 Opened 10 years ago Closed 10 years ago

Robocop testNewTab sometimes fails on x86 emulator / RAZR

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

make checks for tab count more robust
2.46 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
Robocop's testNewTab fails intermittently when run on the x86 emulator setup (see bug 891959). It also fails intermittently locally when run on a Motorola Razr i (XT890).

This may be a fails-on-Jellybean rather than a fails-on-x86 problem, but it is the effort to get tests running on x86 that is bringing about this bug.
I am surprised this test hasn't given us more trouble! The test opens tabs and then immediately fetches a UI element to check the tab count. Of course there can be a delay before the view is updated with the new count.

This patch allows for a short delay before the tab count is updated -- solves the intermittent failures seen on the RAZR.
Attachment #783218 - Flags: review?(jmaher)
Blocks: 892688
No longer blocks: 891959
Comment on attachment 783218 [details] [diff] [review]
make checks for tab count more robust

Review of attachment 783218 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #783218 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/e8d0ffd59e68
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Blocks: 936226
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.