89966 - MfcEmbed's PromptService implementation not complete..

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Chak Nanga]

Currently MFcEmbed's PromptService is not fully implemented.

Specifically, we need to impl the following methods:

ConfirmCheck
ConfirmEx
Select

Comment 1

[Chak Nanga]

The methods which are to be implemented are:
   ConfirmCheck
   ConfirmEx
   AlertCheck

not

   ConfirmCheck
   ConfirmEx
   Select  (Which no one ever seems to call)

Comment 2

[Chak Nanga]

Attachment: Patch to impl ConfirmCheck, ConfirmEx and AlertCheck methods

Comment 3

[Chak Nanga]

Hi Adam : Could you please r= this when you get a chance....Thanks

Comment 4

[Chak Nanga]

Hi Dan : Could you please r= this since Adam's on vacation....Thanks

Comment 5

[Chak Nanga]

Hi Conrad : Since both Adam and Danm are on vacation, would you be able to r=
this when you get a chance...Thanks

Comment 6

[Conrad Carlen (not reading bugmail)]

1) on ConfirmEx, the checkMsg param can be null. If that's the case, the
checkbox should be hidden. Also, checkValue can be null, so check that before
assigning to it.
2) in ConfirmEx, the setting of the button titles could be a little more
compact. If you had: CString csButtonStrings[3];
and then, in the for() loop, assign in each case to csButtonStrings[i], it would
be more concise and make for a few less initializations and assignments.

Comment 7

[Chak Nanga]

Attachment: Patch based on conrad's comments

Comment 8

[Conrad Carlen (not reading bugmail)]

Looks good, except for this, in the bottom of ConfirmEx:

+    *checkValue = dlg.m_bCheckBoxValue;

There still needs to be a null-check there.
With that, r=ccarlen

Comment 9

[Chak Nanga]

Sorry, missed that one earlier. 

I added the following check:

if(checkValue)
  *checkValue = dlg.m_bCheckBoxValue;

Thanks for your keen eye and a quick review Conrad!

Comment 10

[Chak Nanga]

Hi Chris : Can i get an sr= on this...Thanks

Comment 11

[Christopher Blizzard (:blizzard)]

There are lots of bad tabs in that patch.  Can you fix those, please?  And
remove this stuff:

+ //{{AFX_DATA(CAlertCheckDialog)

etc.

Fix those and you have an sr=blizzard

Comment 12

[Chak Nanga]

Attachment: Patch which incorporates Chris's suggestions

Comment 13

[Chak Nanga]

Patch checked in.

Comment 14

[David Epstein]

 ConfirmCheck, ConfirmEx, & AlertCheck are now implemented in PromptService.