899691 - upgrade puppet-concat to 0.2.0

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This is in preparation for work to add Windows support (bug 891991)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug899691.patch

This change seems to have no effect in my testing.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 783272 [details] [diff] [review]
bug899691.patch

stamp

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 783272 [details] [diff] [review]
bug899691.patch

Review of attachment 783272 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/concat/manifests/setup.pp
@@ -15,2 @@
>  class concat::setup {
> -  include packages::diffutils

This line broke initial puppetization:

Sun Aug 04 16:53:14 -0700 2013 /Stage[main]/Motd::Base/Concat[/etc/motd]/Exec[concat_/etc/motd] (err): Could not evaluate:                                    
/var/lib/puppet/concat/bin/concatfragments.sh: line 125: cmp: command not found                                                                               
                                                                                                                                                              
Sun Aug 04 16:53:18 -0700 2013                                                                                                                                
/Stage[main]/Users::Root::Setup/Ssh::Userconfig[root]/Concat[/root/.ssh/authorized_keys]/Exec[concat_/root/.ssh/authorized_keys] (err): Could not             
evaluate: /var/lib/puppet/concat/bin/concatfragments.sh: line 125: cmp: command not found                                                                     
                                                                                                                                                              
Sun Aug 04 16:53:18 -0700 2013                                                                                                                                
/Stage[main]/Users::Builder::Setup/Ssh::Userconfig[cltbld]/Concat[/home/cltbld/.ssh/authorized_keys]/Exec[concat_/home/cltbld/.ssh/authorized_keys]           
(err): Could not evaluate: /var/lib/puppet/concat/bin/concatfragments.sh: line 125: cmp: command not found                                                    
                                                                                                                                                              
Sun Aug 04 16:53:19 -0700 2013 /Stage[main]/Puppet::Config/Concat[/etc/puppet/puppet.conf]/Exec[concat_/etc/puppet/puppet.conf] (err): Could not              
evaluate: /var/lib/puppet/concat/bin/concatfragments.sh: line 125: cmp: command not found

Comment 4

[Rail Aliiev [:rail]]

Bumping priority because it makes difficult to setup new slaves without manual intervention.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, we should be able to just revert that chunk.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug899691-diffutils.patch

Comment 7

[Rail Aliiev [:rail]]

Thanks for the quick fix.

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

https://hg.mozilla.org/build/puppet/rev/c3d9decb8397