Closed
Bug 89973
Opened 25 years ago
Closed 25 years ago
color picker doesn't show correct color on chip or editfield
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: Brade, Assigned: cmanske)
Details
(Whiteboard: fixed, reviewed, nsBranch+, PDT+)
Attachments
(1 file)
|
607 bytes,
patch
|
Details | Diff | Splinter Review |
In Composer the color picker doesn't show the correct color on the color chip on
the toolbar. Also, the editfield doesn't always show a value when it should.
To reproduce:
type some text in Composer
select the text
choose the text color picker
enter: #eeeeee
click ok
Notice that the color picker shows a white color chip but the text is a very
light gray.
go back to color picker
Notice that the edit field is empty; it should show "#eeeeee"
| Assignee | ||
Comment 1•25 years ago
|
||
This problem occurs when the color typed in is *not* in the array of color
swatches.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
| Assignee | ||
Comment 2•25 years ago
|
||
This bug occurs because of recent change in how color picker is intialized.
We should call "initColor()" else we can't use a color that isn't in the
color swatch array! (Not a good thing.)
Fix is very simple. Nominating to fix for 6.1.
r=sfraser
Severity: normal → major
Whiteboard: fixed, need sr=
Target Milestone: mozilla1.0 → mozilla0.9.3
| Assignee | ||
Comment 3•25 years ago
|
||
Comment 6•25 years ago
|
||
I didn't r= this yet. I said I *would*, not that I *had*
Hardware: Macintosh → All
Comment 7•25 years ago
|
||
ok, r=sfraser
| Assignee | ||
Comment 10•25 years ago
|
||
PDT+ approved by Steve Elmer.
Whiteboard: fixed, reviewed, nsBranch+ → fixed, reviewed, nsBranch+, PDT+
| Assignee | ||
Comment 11•25 years ago
|
||
Checked into branch
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 12•25 years ago
|
||
verified on 7/11 trunk.
now I will verify on the branch.
removing vtrunk keyword
Keywords: vtrunk
Comment 13•25 years ago
|
||
verified on 7/13 branch on windows.
marking verified-fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•