Closed
Bug 899739
Opened 12 years ago
Closed 12 years ago
i18n-abide default an unknown locale to the default language
Categories
(Webmaker Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alicoding, Assigned: humph)
References
Details
Attachments
(1 file)
If the request coming in with an unsupported or unknown language it should be default to the language that we set on the setup.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → david.humphrey
|
Assignee | |
Comment 1•12 years ago
|
||
I've done a pull request for this to abide:
https://github.com/mozilla/i18n-abide/pull/45
The commit we can use until this lands is https://github.com/humphd/i18n-abide/commit/05344a817dca4571a1ae9f502fed1cb118294033
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 2•12 years ago
|
||
Attachment #783334 -
Flags: review?(david.humphrey)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #783334 -
Flags: review?(david.humphrey) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/66b45ac1ec360bd070fa82228b1e0cd772ce4f84
Bug 899739 - Update package.json to use i18n-abide..
Changed i18n-abide in package.json to use humphrey's version while we are waiting
for the PR to be landed, and also add missing key in messages.json
|
|
Reporter | |
Updated•12 years ago
|
|
|
Reporter | |
Comment 4•12 years ago
|
||
I don't think this bug is valid anymore. Should we close this bug?
|
|
Reporter | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•