899875 - pymake doesn't pass quoted empty args to command

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Given the Makefile:

all:
        bash -c 'echo $$#' -- a b "" c

On Win32, GNU make correctly prints 4, pymake prints 3.  The "" is not properly passed to the command.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: handle empty arguments

relatively easy fix, with test.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Better handle empty arguments in pymake, and also treat whitespaces in bulk

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 783531 [details] [diff] [review]
handle empty arguments

Sorry to have hijacked it. I didn't see you had a patch when I bzexported. As having written that particular code, i prefer my patch ;)

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yup, don't care, as long as it works! :)  My patch had a test though, should probably add that one in.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Better handle empty arguments in pymake, and also treat whitespaces in bulk

Added vlad's test (using posix = instead of bashism ==, and adding some more whitespaces that should be treated correctly)

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cc4a6f5d35a

Comment 7

[Mike Hommey [:glandium]]

http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/1cf15f6116e8

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2cc4a6f5d35a