Closed Bug 899881 Opened 7 years ago Closed 7 years ago

don't allow frames to have a null style context

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

Since frames should never have a null style context, we should make SetStyleContext{,WithoutNotification} not null check their arguments.
Attachment #783537 - Flags: review?(dbaron)
Comment on attachment 783537 [details] [diff] [review]
no-null-stylecontext

r=dbaron, but could you also remove the null-check in nsFrame::~nsFrame()?

(And also fix the bug number in the commit message.)
Attachment #783537 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/ce984b387db8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.