Closed Bug 899886 Opened 6 years ago Closed 6 years ago

make nsStyleSet::ReparentStyleContext never return null

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

We never call nsStyleSet::ReparentStyleContext with a null aStyleContext, so let's not return early if it's null, and just assume (and assert) that it's non-null.
Attachment #783545 - Flags: review?(dbaron)
Comment on attachment 783545 [details] [diff] [review]
reparentstylecontext-no-return-null

r=dbaron, though maybe it should be MOZ_ASSERT
Attachment #783545 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/5b3ec8bf8bbc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.