Closed Bug 899896 Opened 6 years ago Closed 6 years ago

avoid null checking of some box layout factory functions

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
There are three NS_NewBlahFrame functions that explicitly return null, and they all do so if a NS_NewBlahLayout function fails.  We can remove these null checks/returns, since the NS_NewBlahLayout functions all just call ::operator new.
Attachment #783560 - Flags: review?(dbaron)
Comment on attachment 783560 [details] [diff] [review]
patch

r=dbaron
Attachment #783560 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/6c032632b905
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.