Closed Bug 899900 Opened 10 years ago Closed 10 years ago

don't null check NS_NewBlahFrame return values

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

null-check-nsnewframe
11.29 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
All of the NS_NewBlahFrame factory functions allocate from the pres shell's arena, which is infallible.  We can remove the null checks of their return values.
Attachment #783576 - Flags: review?(dbaron)
Depends on: 899896
Comment on attachment 783576 [details] [diff] [review]
null-check-nsnewframe

r=dbaron
Attachment #783576 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/dc5bce83d801
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.