Closed
Bug 899936
Opened 8 years ago
Closed 8 years ago
OdinMonkey: fix faulty floating point logic in ExtractNumericLiteral
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
5.63 KB,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
The current integer-overflow handling in ExtractNumericLiteral casts doubles to int64 when the double can be inf, -inf, or outside the int64 range. There are unit tests that would have caught this but all the platforms on tbpl apparently cast these extremal doubles to out-of-range int64 values so the correct result is produced (NumLit::OutOfRangeInt). However, qemu and Marty's pandaboard expose the bug. Thanks to marty for helping to track this down.
Attachment #783657 -
Flags: review?(mrosenberg)
Updated•8 years ago
|
Attachment #783657 -
Flags: review?(mrosenberg) → review+
![]() |
Assignee | |
Comment 1•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eef74151413
Comment 2•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3eef74151413
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•