OdinMonkey: fix faulty floating point logic in ExtractNumericLiteral

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla25
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 783657 [details] [diff] [review]
fix and tests

The current integer-overflow handling in ExtractNumericLiteral casts doubles to int64 when the double can be inf, -inf, or outside the int64 range.  There are unit tests that would have caught this but all the platforms on tbpl apparently cast these extremal doubles to out-of-range int64 values so the correct result is produced (NumLit::OutOfRangeInt).  However, qemu and Marty's pandaboard expose the bug.  Thanks to marty for helping to track this down.
Attachment #783657 - Flags: review?(mrosenberg)
Attachment #783657 - Flags: review?(mrosenberg) → review+
(Assignee)

Comment 1

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eef74151413
https://hg.mozilla.org/mozilla-central/rev/3eef74151413
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.