899971 - DebuggerServer.onSocketAccepted should take an async allow callback

Status: RESOLVED INVALID

(DevTools :: Debugger, defect, P3)

Description

[Chenxia Liu [:liuche]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/main.js#437

The allow callback might very well take user input, so it doesn't make sense for the debugger service to require a synchronous callback and offload response waiting to the caller.

Comment 1

[Chenxia Liu [:liuche]]

Relevant snippet:

> onSocketAccepted:
>    makeInfallible(function DS_onSocketAccepted(aSocket, aTransport) {
>      if (promptConnections && !this._allowConnection()) {
>        return;
>      }

Or as mentioned earlier, use Promises instead.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

+1 for promises since the debugger server has embraced them for the most part

Comment 3

[Jason Laster [:jlast]]

nolonger relevant