899979 - jsapi-test/testRegExpInstanceProperties.cpp is not compiled

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

As discovered in bug 896949, this file was removed from the build, but not version control, with the following change:

Bug 648355 - Disable a fragile JSAPI test that seems to have been kicked into failure likely by compiler-determined optimizations, or something similarly undefined and maybe now impossible to rely upon -- but we'll see. For now, just return to green and really deal with it later. r=orange

author	Jeff Walden <[e-mail]>
	Fri Apr 08 15:24:00 2011 -0700 (at Fri Apr 08 15:24:00 2011 -0700)

The bug number is wrong though.

The code as it stands doesn't compile.

Comment 1

[Jon Coppeard (:jonco)]

Jeff, do you remember what the problem was this test caused?  Do you think this test is worth fixing or should we just remove it?

Comment 2

[Jeff Walden [:Waldo]]

Remove it.  ES6 last I heard made all the RegExp instance data properties into accessor properties on RegExp.prototype, which would eliminate the mess of complexity this test was designed to exercise.  So there's no good reason for it any more once we make that change.  I tend to think, for consistency, we should make that change before removing this test file.  It shouldn't be too bad, possibly may even let us kill off current RegExp complexity that'll no longer be needed once those properties are accessorized.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: bug899979-remove-unused-test-code

This change seems to have happened now in bug 1120169, so removing the file.

Comment 4

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fe43cd0ac7d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4fe43cd0ac7d