[XUL Syntax] Remove support for align="vertical" in <box> and <window>

RESOLVED FIXED

Status

()

RESOLVED FIXED
17 years ago
10 years ago

People

(Reporter: hamfastgamgee, Assigned: hamfastgamgee)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

17 years ago
This bug is spun off from bug 70857.  When commercial is updated to cover its 
instances by jag, the changes to remove the deprecated support for 
align="vertical" in <box> and <window> in the Mac and Windows Classic skins will 
be landed.  After that happens, only <scrollbar>, <thumb>, and <slider> will 
legitimately use align="vertical" and align="horizontal" (for unknown and 
mysterious reasons).

Comment 1

17 years ago
Netscape side has been fixed, ready when you are :-)
(Assignee)

Comment 2

17 years ago
Created attachment 43325 [details] [diff] [review]
Die, align="vertical"! (r=timeless, sr=blake)

Comment 3

17 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

17 years ago
Reopening, as it seems this support is still available in C++.  With 90001 fixed 
now, I can't find any instances of align="vertical|horizontal" in the tree 
(other than a couple of test files), so I'll attach a patch for the removal of 
the deprecated C++ support for it (in addition to fixes for those test files, 
even though that's utterly trivial).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

17 years ago
Created attachment 44835 [details] [diff] [review]
Trivial patch to scrollbar tests (woo-freakin'-hoo)

Comment 6

17 years ago
r=hewitt
checked in

leaving open for getting rid of the c++ support.
(Assignee)

Comment 8

17 years ago
Created attachment 44937 [details] [diff] [review]
Patch to widgets.xul (last align="vertical|horizontal" in something other than nsMimeXULEmitter.cpp)

Comment 9

17 years ago
sr=blake

Comment 10

17 years ago
r=kerz
checked in.  Still leaving open for c++ changes
(Assignee)

Comment 12

17 years ago
Created attachment 44987 [details] [diff] [review]
At long last, the C++ removal of align="vertical|horizontal"

Comment 13

17 years ago
r=timeless
Keywords: approval, patch

Comment 14

17 years ago
sr=hyatt (and there was much rejoicing!)

Updated

17 years ago
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 15

17 years ago
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.cpp,v  <--  nsBoxFrame.cpp
new revision: 1.150; previous revision: 1.149
done

According to my count, that's the last of it. Someone gets to send the final 
announcement to npm.<whatever> reminding that mozilla no longer supports it, 
unless that was already done...

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.