900011 - contentDescription missing again from Search or Go image button to the right of the text field

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Marco Zehe (:MarcoZ)]

For some reason, bug 779448 is back, after it worked for quite a number of versions.

Comment 1

[Aaron Train [:aaronmt]]

Regression from bug 734877? http://hg.mozilla.org/mozilla-central/rev/696633740d85

Comment 2

[Max Li [:maxli]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Regression from bug 734877?
> http://hg.mozilla.org/mozilla-central/rev/696633740d85

Nope. Starts occurring on the July 23 build.

So somewhere in here:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2268ff80683a&tochange=5ceea82a79c7

Comment 3

[Max Li [:maxli]]

This is regressed from bug 895236; since the state is now properly set when initialized, the update sequence is no longer called. So we should set the initial content description in a manner similar to the initial image is set.

Comment 4

[Max Li [:maxli]]

Attachment: Patch

Comment 5

[:Margaret Leibovic]

I added a point about this to our reviewer checklist:
https://developer.mozilla.org/en-US/docs/Developer_Guide/Reviewer_Checklist#Accessibility

Feel free to edit that point (or add more points). I feel like this is an issue that we should try to catch during review.

Comment 6

[Max Li [:maxli]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f43bbdf342

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2f43bbdf342