Filename entered in the 'Attachment Filename' field doesn't have any effect on uploaded patch filename

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: emorley, Assigned: gps)

Tracking

Trunk
x86_64
Windows 8

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1) bz export -e
2) Change the filename in the 'Attachment Filename' field.
3) Let the patch attach.
4) Check the bug and see what filename is specified in the patch details view

Expected:
Attached patch filename matches the new one entered in the editor.

Actual:
Attached patch filename is the same as the original filename.
(Reporter)

Comment 1

5 years ago
(eg happened in bug 900010)
(Assignee)

Comment 2

5 years ago
I /think/ this is biting me in bug 928195. Since I'm not using mq, patch filenames default to '.'. Whenever I upload patches to a multi-part bug, the old attachments are obsoleted at upload time.

STR:

1) hg gdown
2) hg bzexport -e
3) hg gup
4) hg bzexport -e -> part 1 was deleted.
(Assignee)

Comment 3

5 years ago
Created attachment 832324 [details] [diff] [review]
Record attachment filename in upload

The first time I looked at the source of bzexport in detail. Oh boy.
Attachment #832324 - Flags: review?(sphink)
(Assignee)

Updated

5 years ago
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #832324 - Flags: review?(sphink) → review+
(Assignee)

Comment 4

5 years ago
Committed as c604ded99c59.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.