900013 - Filename entered in the 'Attachment Filename' field doesn't have any effect on uploaded patch filename

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Ed Morley [:emorley]]

1) bz export -e
2) Change the filename in the 'Attachment Filename' field.
3) Let the patch attach.
4) Check the bug and see what filename is specified in the patch details view

Expected:
Attached patch filename matches the new one entered in the editor.

Actual:
Attached patch filename is the same as the original filename.

Comment 1

[Ed Morley [:emorley]]

(eg happened in bug 900010)

Comment 2

[Gregory Szorc [:gps]]

I /think/ this is biting me in bug 928195. Since I'm not using mq, patch filenames default to '.'. Whenever I upload patches to a multi-part bug, the old attachments are obsoleted at upload time.

STR:

1) hg gdown
2) hg bzexport -e
3) hg gup
4) hg bzexport -e -> part 1 was deleted.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Record attachment filename in upload

The first time I looked at the source of bzexport in detail. Oh boy.

Comment 4

[Gregory Szorc [:gps]]

Committed as c604ded99c59.