Closed Bug 900016 Opened 10 years ago Closed 8 years ago

PJS: intrinsics taking ThreadSafeContext should not have declarations taking JSContext

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: pnkfelix, Unassigned)

References

Details

In js/src/jscntxt.h, the Dump and Spew intrinsics are declared as taking a JSContext* as their first argument, but their actual definitions take ThreadSafeContext* (which is a base class of JSContext).

This is a minor bug that manifests itself in linking errors if one attempts to call these intrinsics with a JSContext* (because the compiler assumes the function is overloaded, and so the linker seeks an external definition matching the exact type signature as given, but no such definition is available).

We should either fix the declarations in the header file, or remove the two declarations entirely from that header file.
Assignee: general → nobody
Blocks: PJS
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.