900016 - PJS: intrinsics taking ThreadSafeContext should not have declarations taking JSContext

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

In js/src/jscntxt.h, the Dump and Spew intrinsics are declared as taking a JSContext* as their first argument, but their actual definitions take ThreadSafeContext* (which is a base class of JSContext).

This is a minor bug that manifests itself in linking errors if one attempts to call these intrinsics with a JSContext* (because the compiler assumes the function is overloaded, and so the linker seeks an external definition matching the exact type signature as given, but no such definition is available).

We should either fix the declarations in the header file, or remove the two declarations entirely from that header file.