900028 - Can't install reviewer signed apps from Marketplace on 1.1

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

Trying to install the test app I uploaded to make sure the redirects property works on 1.1 (https://marketplace.firefox.com/reviewers/apps/review/redirected) I get 'download stopped' on my 1.1 unagi.

logcat shows the following:

E/GeckoConsole(  107): Content JS INFO at app://system.gaiamobile.org/js/app_install_manager.js:197 in ai_handleDownloadError: downloadError event, error code is INVALID_IDS_JSON

The same app installs on my 1.0.1 unagi; I have the same reviewer certs installed, with the same scripts, as on 1.0.1.

This is going to stop all Marketplace reviewers from testing and approving apps that support 1.1.

Comment 1

[Andrew Williamson [:eviljeff]]

Attachment: redirects app reviewer signed package

attaching the zip file.

All packaged apps from the reviewer tools I've tried fail to install, not just this app.

Comment 2

[Jason Smith [:jsmith]]

That error points to:

http://hg.mozilla.org/mozilla-central/annotate/ffd57aa81b5f/dom/apps/src/Webapps.jsm#l2649

Which was implemented in the 1.1 timeframe for verifying the ids.json file during install/update.

Antonio probably has an idea why this is failing.

Comment 3

[Antonio Manuel Amaya Calvo (:amac)]

The version on the attached file is a string, and it should be a integer (that is, it should be:

{"version": 1477934, "id": "48a3843e-5c64-4e07-84b7-ef53b7cdb669"}

instead of

{"version": "1477934", "id": "48a3843e-5c64-4e07-84b7-ef53b7cdb669"}

I think it's failing because of that (as it should according to [1])

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

What are you using to sign the apps? I think the problem might be there. On bug 870920 the marketplace signing app was fixed to generate the ids.json correctly... this might have been left behind?

Comment 4

[Jason Smith [:jsmith]]

Looks like this is a problem on the marketplace side - the version value is incorrectly a string, when it should be an integer.

Rob - Can you look into this?

Comment 5

[Mathieu Pillard [:mat]]

I just submitted a PR for this, I'm not familiar at all with the signing code and I can't test it locally but it seems to fix it. https://github.com/mozilla/zamboni/pull/959

Comment 6

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/cd615659a6a0eba39ffeff35147fb1f8676027e5

Comment 7

[Mathieu Pillard [:mat]]

Andrew said on IRC we couldn't test that on -dev, but I swear it should work!