Closed
Bug 900053
Opened 11 years ago
Closed 11 years ago
knox adds a ":" at the end of a domain if there is an empty S3_PORT value
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
Details
(Whiteboard: s=20130729 p=1)
Attachments
(1 file)
This causes thimble to generate publish URLs such as https://s3.amazonaws.com:/org.webmadecontent.staging.thimble/mopaxian/thimble/your-awesome-webpage-created-on-wed-31-jul-2013-161702-gmt (note the :), which in turn does not pass mongo's URL validation.
turns out 0.8.5 was not enough to fix, we still need a workaround while the issue is addressed in knox itself.
Attachment #783814 -
Flags: review?(cade)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 783814 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/191/files
r+
Attachment #783814 -
Flags: review?(cade) → review+
|
||
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/817fc86dae6dbcb81b5c3f50397ad4a13cc4e0b0
Merge pull request #191 from Pomax/bug900053
Bug900053
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•