Closed Bug 900070 Opened 11 years ago Closed 11 years ago

Ignorable intermittent "ValueError: Unknown format code 'f' for object of type 'str'" from mozharness/base/python.py::log_usage()

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

Product:
Release Engineering
Component:
Applications: MozharnessCore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: jyeo)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Round cpu_percent if not None
1.92 KB, patch
mozilla
: review+
jyeo
: checked-in+
Details | Diff | Splinter Review 
b2g_emulator_vm mozilla-central opt test mochitest-3 on 2013-07-31 07:01:22 PDT for push ffd57aa81b5f

slave: tst-linux64-ec2-323

https://tbpl.mozilla.org/php/getParsedLog.php?id=25971358&tree=Mozilla-Central

{
07:43:43  WARNING - # TBPL WARNING #
07:43:43  WARNING - The mochitest suite: mochitest-3 ran with return status: WARNING
07:43:43     INFO - Running post-action listener: _resource_record_post_action
07:43:43     INFO - Running post-run listener: _resource_record_post_run
07:43:44     INFO - Total resource usage - Wall time: 2463s; CPU: 93%; Read bytes: 41054208; Write bytes: 380198912; Read time: 15788; Write time: 1539800
07:43:44  WARNING - Exception when formatting: Traceback (most recent call last):
07:43:44  WARNING -   File "/builds/slave/test/scripts/mozharness/base/python.py", line 458, in log_usage
07:43:44  WARNING -     io_write_time=io.write_time))
07:43:44  WARNING - ValueError: Unknown format code 'f' for object of type 'str'
07:43:44     INFO - run-tests - Wall time: 2463s; CPU: 93%; Read bytes: 37572608; Write bytes: 380198912; Read time: 15348; Write time: 1539800
}
This is a caught exception, and we're just logging the caught exception.
I assume you want this not logged?
Summary: Intermittent "ValueError: Unknown format code 'f' for object of type 'str'" from mozharness/base/python.py::log_usage() → Ignorable intermittent "ValueError: Unknown format code 'f' for object of type 'str'" from mozharness/base/python.py::log_usage()
ResourceMonitor.aggregate_cpu_percent returns None when it can't collect cpu_percent. (https://github.com/mozilla/mozbase/blob/0a1214782a81dc0cde21d001bcfd737c8a860ebb/mozsystemmonitor/mozsystemmonitor/resourcemonitor.py#L386)

This patch should suppress that warning.
Attachment #787585 - Flags: review?(aki)
Comment on attachment 787585 [details] [diff] [review]
Round cpu_percent if not None

You rock.
Attachment #787585 - Flags: review?(aki) → review+
Thank you :-)
Assignee: nobody → yshun
Attachment #787585 - Flags: checked-in+
Product: mozilla.org → Release Engineering
Code live: merged to production.
Ty :-)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Mass back out from production.
We should figure out in Cedar if this is involved with the tree burning.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Merged again to the production branch of mozharness.
Live as of ~7:40AM PDT.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: