Selected Tab may or may not get shown in the scrollbox while overflowed

RESOLVED FIXED in Thunderbird 26.0

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jsbruner, Assigned: jsbruner)

Tracking

(Blocks: 1 bug)

25 Branch
Thunderbird 26.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

At least on Daily, selecting a tab may or may not cause the scrollbox to scroll over and show this tab. For example:

Opening many tabs that cause the scrollbox to enter overflow mode will show the last tab, but not completely. Only about 3/4 of the tab is scrolled into view. My guess here is that we are only checking that the center point of the tab is visible.

Trying to then use the tab drop-down and pick a tab causes the tab to become selected, but without the scrollbox moving over at all.
Created attachment 788567 [details] [diff] [review]
Patch.

Really simple fix. Letting Mike review this, though it shouldn't take long at all.
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Attachment #788567 - Flags: review?(mconley)
Comment on attachment 788567 [details] [diff] [review]
Patch.

Review of attachment 788567 [details] [diff] [review]:
-----------------------------------------------------------------

While this doesn't appear the scroll *the entire* tab into view, I'll say it's a heck of a lot better than what we're currently doing. Thanks Josiah!

Just one nit, and then you're good to land.

::: mail/base/content/tabmail.xml
@@ +2001,5 @@
>        </method>
>      </implementation>
>      <handlers>
>        <handler event="select"><![CDATA[
> +        this._handleTabSelect();

Please fix the indentation here.
Attachment #788567 - Flags: review?(mconley) → review+
OS: Mac OS X → All
Created attachment 801773 [details] [diff] [review]
Patch.

Thanks Mike!
Attachment #788567 - Attachment is obsolete: true
Attachment #801773 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7e57591c0949
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in before you can comment on or make changes to this bug.