900156 - [newsletter] L10n of /confirm page

Status: VERIFIED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Jessilyn Davis]

Howdy!

We're in the process of moving all the newsletter pages to bedrock and ran across some missing l10n strings on https://www.mozilla.org/newsletter/confirm/ for these locales:

de, ru, id, es, pt-BR, fr, pl


I think there are 10 or less strings on deck that need l10n. Can you help? If so, how quickly can they be updated?


Thanks!

Jess

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

I'll work on that this week

Comment 2

[Jessilyn Davis]

hu needs to be added to the list as well.

Comment 3

[Francesco Lodolo [:flod]]

I'll let Pascal answer to be sure but I think this is already done (strings were added for all locales).
http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=newsletter.lang

Of the above list these are the complete locales: de, es, fr, hu, pl. We're still behind with pt-BR and id (pinged both localizers without results last week).

This answer is valid for bug 867764 as well. I'll talk with Pascal today and try to understand if we can speed things up with those two locales.

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

It looks like it is done yes, I also contacted pt-BR and id localizers today. Jessilyn, have you tested the pages on the staging server to make sure we haven't forgotten strings?

Comment 5

[Jessilyn Davis]

I just took a look and it appears that /confirm works in all the locales (including pt-BR and id) - except for hu.  This wasn't on the original list, but was added later in Comment 2. Is it possible to get this page localized fairly quickly in hu?

Comment 6

[Francesco Lodolo [:flod]]

http://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=newsletter.lang
Strings are completely localized for Hungarian, I don't know if locales must be enabled somewhere else for newsletter. Pascal?

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

I looked at the code and there is now a settings/newsletter.py file on bedrock which has the activated locales listed, I created a pull request to get this list updated this list in https://github.com/mozilla/bedrock/pull/1223 We should probably check that there is nothing else to do to add a locale with pmac

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e8a4b93145458d3b2f006c467d7ac54bf2650450
Bug 900156: add Hungarian (hu) to supported locales for the newsletter

https://github.com/mozilla/bedrock/commit/b0288d184e95d289511847788c1451584e3ecf16
Merge pull request #1223 from pascalchevrel/Bug-900156-newsletter_l10n

Bug 900156: add Hungarian (hu) to supported locales for the newsletter

Comment 9

[Dan Poirier [:dpoirier]]

That settings/newsletter.py file is a fallback if bedrock can't get to basket to get the real newsletter data. 'hu' did need to be added, but I doubt that was the cause of not getting those messages.  Maybe production basket doesn't list 'hu' as a supported language for any newsletters yet?

Comment 10

[Jessilyn Davis]

(In reply to Dan Poirier [:dpoirier] from comment #9)
> Maybe production
> basket doesn't list 'hu' as a supported language for any newsletters yet?

'hu' was on the list of languages for basket-dev.

I just stage and dev and stage for hu/newsletter/confirm/TOKEN and I kept getting 404 errors. Dan is that still expected or a bug?

Comment 11

[Dan Poirier [:dpoirier]]

The only /LANG/newsletter/confirm URL that goes to Bedrock right now is /en-US/newsletter/confirm/*.  So /hu/newsletter/confirm would have gone to the old site, and I don't know if that's supposed to work or not.  Or whether we're supposed to be sending more languages to Bedrock ... pmac?

Comment 12

[Paul [:pmac] McLanahan]

The confirm page appears to be there on the PHP side for locales but it seems to not be working. I'm not sure what the deal is.... what's the format of the confirm links from the emails?

Comment 13

[Paul [:pmac] McLanahan]

Nevermind. They do work fine with a token. And the bedrock one seems to also work fine and is translated:

https://www-dev.allizom.org/b/fr/newsletter/confirm/3d221319-c3e3-44b3-ba13-c140463ff946/

We just need to activate the lang files. Do you know which langs Jess? Same as for /existing?

Comment 14

[Jessilyn Davis]

*whew* good to know they work okay. 

Same languages as /existing please. Thanks!

Comment 15

[Paul [:pmac] McLanahan]

Activated in prod in r120031. These won't do anything until we alter the apache config to point all locales to bedrock. I'll submit a PR shortly for that.

Comment 16

[Paul [:pmac] McLanahan]

Attachment: Pointer to Github pull request: https://github.com/mozilla/bedrock/pull/1239

Pointer to Github pull-request

Comment 17

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9230ce946c90cf905b0325d703bf88242186a8b9
Bug 900156: Enable locales for /newsletter/confirm/

https://github.com/mozilla/bedrock/commit/f0ff35a236c8b3ffc630e5d9bad9996dbdf4d79e
Merge pull request #1239 from pmclanahan/newsletter-confirm-for-locales-900156

Bug 900156: Enable locales for /newsletter/confirm/

Comment 18

[Paul [:pmac] McLanahan]

Working well on prod!

https://www.mozilla.org/fr/newsletter/confirm/3d221319-c3e3-44b3-ba13-c140463ff946/

Comment 19

[Jessilyn Davis]

\o/