900160 - postinstall bower command does not work on windows.

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Pomax]

The bower post install command, https://github.com/mozilla/webmaker.org/blob/master/package.json#L7, does not work on windows, as "bower" is not a real program. In order to make this work in windows, the command has to be a form of "bower.cmd install" so we might need to think hard here. This step has to work on every OS.

Comment 1

[Pomax]

we can just require npm install -g bower, and then call "bower". This will solve the problem but will require README.md udpates everywhere.

Comment 2

[Pomax]

package.json shows postinstall is already "bower install", closing as no longer valid.

Comment 3

[Pomax]

was totally looking at the wrong component. reopening.

Comment 4

[Pomax]

Attachment: https://github.com/mozilla/webmaker.org/pull/503

our README.md already tells people to install bower as global command, this patch brings package.json in line with that, and fixes the incompatibility with Windows at the same time.

Comment 5

[Jon Buckley [:jbuck]]

Comment on attachment 833208 [details] [review]
https://github.com/mozilla/webmaker.org/pull/503

Just remove bower and grunt-cli as dev deps, r+ with that

Comment 6

[Pomax]

Comment on attachment 833208 [details] [review]
https://github.com/mozilla/webmaker.org/pull/503

updated and set to ?jbuck as requested on IRC

Comment 7

[Pomax]

added bower back in, https://travis-ci.org/mozilla/webmaker.org/builds/14156200 fails without it.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/a10be81f015474e3e0301be2b0e72eacde2f7dc5
Merge pull request #503 from Pomax/bug900160

made bower a dev dep. since we already require it globally