[fig] Remove overdraws from child fragments in history panel

RESOLVED FIXED in Firefox 26

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Shilpan Bhagat, Assigned: Shilpan Bhagat)

Tracking

unspecified
Firefox 26
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-fig)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Child fragments in history panel currently draws a background which is not needed.
(Assignee)

Updated

5 years ago
Assignee: nobody → sbhagat
OS: Mac OS X → Android
Hardware: x86 → ARM
(Assignee)

Comment 1

5 years ago
Created attachment 783954 [details] [diff] [review]
Patch: Removing overdraws from child fragments in history panel

This patch removes the overdraw.
Attachment #783954 - Flags: review?(sriram)
Comment on attachment 783954 [details] [diff] [review]
Patch: Removing overdraws from child fragments in history panel

Review of attachment 783954 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
But why do we have an unnecessary LinearLayout in the last two XMLs? Wouldn't a home_list_view_with_title alone be enough?? File a separate bug and investigate.
Attachment #783954 - Flags: review?(sriram) → review+

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1cc7d733d8c1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.